refactor: flatten session open flow - #296
Merged
Merged
Conversation
|
thymikee
changed the title
thymikee
marked this pull request as ready for review
March 27, 2026 12:52
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
thymikee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flatten the session
openflow by moving the control flow back intosession-open.tsand reducingsession-open-prepare.tsto small helper functions.This removes the old prepared-command abstraction, keeps validation to a single pass per path, and uses an explicit discriminated result when preparing open details so the handler does not rely on fragile shape checks.
Validation
pnpm formatpnpm typecheckpnpm test:unitpnpm test:smoke